gbranden pushed a commit to branch master
in repository groff.

commit 1e40fbe36ee1831377cfb951f21503df9520d068
Author: G. Branden Robinson <[email protected]>
AuthorDate: Fri Apr 17 07:21:00 2026 -0500

    src/roff/troff/env.cpp: Trivially refactor (1/3).
    
    * src/roff/troff/env.cpp (read_hyphenation_patterns_from_file): Rename
      function parameter `append` to `appending`.  (Elsewhere, we have
      member functions named `append()` that have side effects.)
---
 ChangeLog              | 7 +++++++
 src/roff/troff/env.cpp | 8 ++++----
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 05f180ba2..29596a21d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2026-04-17  G. Branden Robinson <[email protected]>
+
+       * src/roff/troff/env.cpp (read_hyphenation_patterns_from_file):
+       Trivially refactor.  Rename function parameter `append` to
+       `appending`.  (Elsewhere, we have member functions named
+       `append()` that have side effects.)
+
 2026-04-18  G. Branden Robinson <[email protected]>
 
        * src/roff/groff/tests/dot-nm-register-works.sh: Repair test
diff --git a/src/roff/troff/env.cpp b/src/roff/troff/env.cpp
index 70d115b96..3af1829be 100644
--- a/src/roff/troff/env.cpp
+++ b/src/roff/troff/env.cpp
@@ -4857,14 +4857,14 @@ static void hyphenate(hyphen_list *h, unsigned int 
flags)
   }
 }
 
-static void read_hyphenation_patterns_from_file(bool append)
+static void read_hyphenation_patterns_from_file(bool appending)
 {
   char *filename = read_rest_of_line_as_argument();
   if (filename != 0 /* nullptr */) {
     if (0 /* nullptr */ == current_language)
       error("no current hyphenation language");
     else
-      current_language->patterns.read_patterns_file(filename, append,
+      current_language->patterns.read_patterns_file(filename, appending,
        &current_language->exceptions);
   }
 }
@@ -4877,7 +4877,7 @@ static void load_hyphenation_patterns_from_file_request() 
// .hpf
     skip_line();
     return;
   }
-  read_hyphenation_patterns_from_file(false /* append */);
+  read_hyphenation_patterns_from_file(false /* appending */);
   skip_line();
 }
 
@@ -4889,7 +4889,7 @@ static void 
append_hyphenation_patterns_from_file_request() // .hpfa
     skip_line();
     return;
   }
-  read_hyphenation_patterns_from_file(true /* append */);
+  read_hyphenation_patterns_from_file(true /* appending */);
   skip_line();
 }
 

_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit

Reply via email to