gbranden pushed a commit to branch master
in repository groff.
commit 7c1fd40c0ff9b8792537e4b96b633c9d4c3857f8
Author: G. Branden Robinson <[email protected]>
AuthorDate: Fri May 8 20:54:00 2026 -0500
[gxditview]: Rationalize header file inclusions.
* src/devices/xditview/Dvi.c:
* src/devices/xditview/device.c:
* src/devices/xditview/font.c: Arrange inclusions of C standard library
header files before X11 ones. Within such inclusions, sort header
file names in alphabetical order.
---
ChangeLog | 8 ++++++++
src/devices/xditview/Dvi.c | 6 ++++--
src/devices/xditview/device.c | 7 ++++---
src/devices/xditview/font.c | 8 +++++---
4 files changed, 21 insertions(+), 8 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index ca9ed5154..6462b4961 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2026-05-08 G. Branden Robinson <[email protected]>
+
+ * src/devices/xditview/Dvi.c:
+ * src/devices/xditview/device.c:
+ * src/devices/xditview/font.c: Arrange inclusions of C standard
+ library header files before X11 ones. Within such inclusions,
+ sort header file names in alphabetical order.
+
2026-05-08 G. Branden Robinson <[email protected]>
* src/devices/grotty/tty.cpp (tty_font::handle_x_command): Fix
diff --git a/src/devices/xditview/Dvi.c b/src/devices/xditview/Dvi.c
index 26f0ee6bf..52ff2ba9f 100644
--- a/src/devices/xditview/Dvi.c
+++ b/src/devices/xditview/Dvi.c
@@ -2,6 +2,10 @@
#include <config.h>
#endif
+#include <stdio.h>
+#include <ctype.h>
+#include <string.h> // strcmp(), strcpy(), strlen()
+
#ifndef SABER
#ifndef lint
static char Xrcsid[] = "$XConsortium: Dvi.c,v 1.9 89/12/10 16:12:25 rws Exp $";
@@ -22,8 +26,6 @@ static char Xrcsid[] = "$XConsortium: Dvi.c,v 1.9 89/12/10
16:12:25 rws Exp $";
#include <X11/IntrinsicP.h>
#include <X11/StringDefs.h>
#include <X11/Xmu/Converters.h>
-#include <stdio.h>
-#include <ctype.h>
#include "DviP.h"
#include "font.h"
diff --git a/src/devices/xditview/device.c b/src/devices/xditview/device.c
index 2286db1ce..8e49d8a09 100644
--- a/src/devices/xditview/device.c
+++ b/src/devices/xditview/device.c
@@ -21,10 +21,11 @@ along with this program. If not, see
<http://www.gnu.org/licenses/>. */
#include <config.h>
#endif
-#include <stdio.h>
#include <ctype.h>
-#include <stdlib.h>
-#include <string.h>
+#include <stdio.h>
+#include <stdlib.h> // strtol()
+#include <string.h> // strcat(), strchr(), strcmp(), strcpy(),
+ // strlen(), strtok()
#include <X11/Xos.h>
#include <X11/Intrinsic.h>
diff --git a/src/devices/xditview/font.c b/src/devices/xditview/font.c
index 419de4bf3..6a4c67266 100644
--- a/src/devices/xditview/font.c
+++ b/src/devices/xditview/font.c
@@ -8,12 +8,14 @@
#include <config.h>
#endif
+#include <ctype.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h> // strcmp(), strcpy(), strlen(), strncpy()
+
#include <X11/Xos.h>
#include <X11/IntrinsicP.h>
#include <X11/StringDefs.h>
-#include <stdio.h>
-#include <ctype.h>
-#include <stdlib.h>
#include "DviP.h"
#include "XFontName.h"
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
