gbranden pushed a commit to branch master
in repository groff.
commit 844bc82ce65c31428677c1d8873e66def8983da1
Author: G. Branden Robinson <[email protected]>
AuthorDate: Fri May 15 12:04:42 2026 -0500
[hpftodit]: Give command a proper header file.
...for external symbol.
* src/utils/hpftodit/hpftodit.cpp: Move `extern` declaration of symbol
defined in "hpuni.cpp" from here...
* src/utils/hpftodit/hpftodit.h: ...to this new file.
* src/utils/hpftodit/hpftodit.cpp:
* src/utils/hpftodit/hpuni.cpp: Preprocessor-include new file.
* src/utils/hpftodit/hpftodit.am: Add new file to `hpftodit_SOURCES`
macro definition.
Fixes `-Wmissing-declarations` GCC warning.
---
ChangeLog | 13 +++++++++++++
src/utils/hpftodit/hpftodit.am | 2 +-
src/utils/hpftodit/hpftodit.cpp | 3 ++-
src/utils/hpftodit/hpftodit.h | 2 ++
src/utils/hpftodit/hpuni.cpp | 4 +++-
5 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 2eed6c915..f71e0050f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2026-05-15 G. Branden Robinson <[email protected]>
+
+ [hpftodit]: Give command a proper header file for external
+ symbol.
+
+ * src/utils/hpftodit/hpftodit.cpp: Move `extern` declaration of
+ symbol defined in "hpuni.cpp" from here...
+ * src/utils/hpftodit/hpftodit.h: ...to this new file.
+ * src/utils/hpftodit/hpftodit.cpp:
+ * src/utils/hpftodit/hpuni.cpp: Preprocessor-include new file.
+ * src/utils/hpftodit/hpftodit.am: Add new file to
+ `hpftodit_SOURCES` macro definition.
+
2026-05-15 G. Branden Robinson <[email protected]>
[groff]: Give command a proper header file for external symbols.
diff --git a/src/utils/hpftodit/hpftodit.am b/src/utils/hpftodit/hpftodit.am
index 8f8a0c98c..138bd8de4 100644
--- a/src/utils/hpftodit/hpftodit.am
+++ b/src/utils/hpftodit/hpftodit.am
@@ -24,9 +24,9 @@ EXTRA_DIST += src/utils/hpftodit/hpftodit.1.man
hpftodit_LDADD = libgroff.a $(LIBM) lib/libgnu.a
hpftodit_SOURCES = \
src/utils/hpftodit/hpftodit.cpp \
+ src/utils/hpftodit/hpftodit.h \
src/utils/hpftodit/hpuni.cpp
-
# Local Variables:
# mode: makefile-automake
# fill-column: 72
diff --git a/src/utils/hpftodit/hpftodit.cpp b/src/utils/hpftodit/hpftodit.cpp
index ba6556ee0..6e8df9b43 100644
--- a/src/utils/hpftodit/hpftodit.cpp
+++ b/src/utils/hpftodit/hpftodit.cpp
@@ -49,8 +49,9 @@ put filename in error messages (or fix lib)
#include "nonposix.h"
#include "unicode.h"
+#include "hpftodit.h" // hp_msl_to_unicode_code()
+
extern "C" const char *Version_string;
-extern const char *hp_msl_to_unicode_code(const char *);
#define equal(a, b) (strcmp(a, b) == 0)
// only valid if is_uname(c) has returned true
diff --git a/src/utils/hpftodit/hpftodit.h b/src/utils/hpftodit/hpftodit.h
new file mode 100644
index 000000000..0766dbe4c
--- /dev/null
+++ b/src/utils/hpftodit/hpftodit.h
@@ -0,0 +1,2 @@
+// hpuni.cpp
+extern const char *hp_msl_to_unicode_code(const char *);
diff --git a/src/utils/hpftodit/hpuni.cpp b/src/utils/hpftodit/hpuni.cpp
index f0dcf5200..c2e770be1 100644
--- a/src/utils/hpftodit/hpuni.cpp
+++ b/src/utils/hpftodit/hpuni.cpp
@@ -29,6 +29,8 @@ along with this program. If not, see
<http://www.gnu.org/licenses/>. */
#include "unicode.h"
+#include "hpftodit.h" // hp_msl_to_unicode_code()
+
struct hp_msl_to_unicode {
char *value;
};
@@ -697,7 +699,7 @@ hp_msl_to_unicode_init::hp_msl_to_unicode_init() {
const char *hp_msl_to_unicode_code(const char *s)
{
hp_msl_to_unicode *result = hp_msl_to_unicode_table.lookup(s);
- return result ? result->value : 0;
+ return result ? result->value : 0 /* nullptr */;
}
// Local Variables:
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
