gbranden pushed a commit to branch master
in repository groff.
commit c960d11cfc91e9ee25e699558e77db5260baab83
Author: G. Branden Robinson <[email protected]>
AuthorDate: Fri May 22 11:22:47 2026 -0500
src/roff/troff/input.cpp: Fix code style nits.
* src/roff/troff/input.cpp
(stringdown_request)
(stringup_request): Fix code style nits; declare as `static`; external
linkage is not required.
Also fix cosmetic code style nit; employ groff-idiomatic function
brace style.
Also fix bass-ackward comments describing request operations.
---
ChangeLog | 7 +++++++
src/roff/troff/input.cpp | 10 ++++++----
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 2450b710a..a100dbd11 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2026-05-22 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/input.cpp
+ (stringdown_request)
+ (stringup_request): Fix code style nits; declare as `static`;
+ external linkage is not required.
+
2026-05-22 G. Branden Robinson <[email protected]>
* src/roff/troff/input.cpp: Trivially refactor and fix code
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index fa3480e42..0e20215f7 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -5868,8 +5868,9 @@ void do_string_case_transform(case_xform_mode mode)
tok.next();
}
-// Uppercase-transform each byte of the string argument's contents.
-void stringdown_request() {
+// Transform each byte of the string argument's contents to lowercase.
+static void stringdown_request() // .stringdown
+{
if (!has_arg()) {
warning(WARN_MISSING, "string downcasing request expects an"
" argument");
@@ -5879,8 +5880,9 @@ void stringdown_request() {
do_string_case_transform(STRING_DOWNCASE);
}
-// Lowercase-transform each byte of the string argument's contents.
-void stringup_request() {
+// Transform each byte of the string argument's contents to uppercase.
+static void stringup_request() // .stringup
+{
if (!has_arg()) {
warning(WARN_MISSING, "string upcasing request expects an"
" argument");
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
