gbranden pushed a commit to branch master
in repository groff.
commit 26d914af1d09f75890cee2c84166a4c6d23ffe23
Author: G. Branden Robinson <[email protected]>
AuthorDate: Thu May 28 15:51:20 2026 -0500
src/roff/troff/div.cpp: Fix code style nit.
* src/roff/troff/div.cpp (top_level_diversion::remove_trap)
(top_level_diversion::remove_trap_at)
(top_level_diversion::change_trap)
(top_level_diversion::print_traps): Fix code style nit. Explicitly
compare variables of pointer type to null pointer literal instead of
letting them pun down to Booleans.
---
ChangeLog | 9 +++++++++
src/roff/troff/div.cpp | 8 ++++----
2 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 2941aaa11..bf6de5707 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2026-05-28 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/div.cpp (top_level_diversion::remove_trap)
+ (top_level_diversion::remove_trap_at)
+ (top_level_diversion::change_trap)
+ (top_level_diversion::print_traps): Fix code style nit.
+ Explicitly compare variables of pointer type to null pointer
+ literal instead of letting them pun down to Booleans.
+
2026-05-28 G. Branden Robinson <[email protected]>
* src/roff/troff/div.cpp (top_level_diversion::add_trap)
diff --git a/src/roff/troff/div.cpp b/src/roff/troff/div.cpp
index 487021830..1a56f4746 100644
--- a/src/roff/troff/div.cpp
+++ b/src/roff/troff/div.cpp
@@ -604,7 +604,7 @@ void top_level_diversion::remove_trap(symbol nam)
assert(!nam.is_null());
if (nam.is_null())
return;
- for (trap *p = page_trap_list; p; p = p->next)
+ for (trap *p = page_trap_list; p != 0 /* nullptr */; p = p->next)
if (p->nm == nam) {
p->nm = NULL_SYMBOL;
return;
@@ -613,7 +613,7 @@ void top_level_diversion::remove_trap(symbol nam)
void top_level_diversion::remove_trap_at(vunits pos)
{
- for (trap *p = page_trap_list; p; p = p->next)
+ for (trap *p = page_trap_list; p != 0 /* nullptr */; p = p->next)
if (p->position == pos) {
p->nm = NULL_SYMBOL;
return;
@@ -622,7 +622,7 @@ void top_level_diversion::remove_trap_at(vunits pos)
void top_level_diversion::change_trap(symbol nam, vunits pos)
{
- for (trap *p = page_trap_list; p; p = p->next)
+ for (trap *p = page_trap_list; p != 0 /* nullptr */; p = p->next)
if (p->nm == nam) {
p->position = pos;
return;
@@ -633,7 +633,7 @@ void top_level_diversion::change_trap(symbol nam, vunits
pos)
void top_level_diversion::print_traps()
{
- for (trap *p = page_trap_list; p; p = p->next)
+ for (trap *p = page_trap_list; p != 0 /* nullptr */; p = p->next)
if (p->nm.is_null())
fprintf(stderr, " empty\n");
else
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
