gbranden pushed a commit to branch master
in repository groff.
commit 18846e2553a874326a6e5688631c84a4a7885a28
Author: G. Branden Robinson <[email protected]>
AuthorDate: Sat Oct 17 10:11:40 2026 -0500
[groff]: Regression-test Savannah #68786.
* src/roff/groff/tests/error-close-request-given-empty-argument.sh:
* src/roff/groff/tests/error-pi-request-given-empty-argument.sh:
* src/roff/groff/tests/error-pso-request-given-empty-argument.sh:
* src/roff/groff/tests/error-sy-request-given-empty-argument.sh: New
file; do it.
* src/roff/groff/groff.am: Update `groff_TESTS` to run tests.
Tests fail at this commit.
---
ChangeLog | 13 +++++++++
src/roff/groff/groff.am | 4 +++
.../error-close-request-given-empty-argument.sh | 32 ++++++++++++++++++++++
.../tests/error-pi-request-given-empty-argument.sh | 32 ++++++++++++++++++++++
.../error-pso-request-given-empty-argument.sh | 32 ++++++++++++++++++++++
.../tests/error-sy-request-given-empty-argument.sh | 32 ++++++++++++++++++++++
6 files changed, 145 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index 2610a90c0..9cab05622 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2026-10-17 G. Branden Robinson <[email protected]>
+
+ [groff]: Regression-test Savannah #68786.
+
+ * src/roff/groff/tests/
+ error-close-request-given-empty-argument.sh:
+ * src/roff/groff/tests/error-pi-request-given-empty-argument.sh:
+ * src/roff/groff/tests/
+ error-pso-request-given-empty-argument.sh:
+ * src/roff/groff/tests/error-sy-request-given-empty-argument.sh:
+ New file; do it.
+ * src/roff/groff/groff.am: Update `groff_TESTS` to run tests.
+
2026-10-16 G. Branden Robinson <[email protected]>
[troff]: Fix Savannah #68784.
diff --git a/src/roff/groff/groff.am b/src/roff/groff/groff.am
index ea8c71c6a..d7975ccac 100644
--- a/src/roff/groff/groff.am
+++ b/src/roff/groff/groff.am
@@ -103,12 +103,16 @@ groff_TESTS = \
src/roff/groff/tests/driver-C-and-G-options-work.sh \
src/roff/groff/tests/dt-request-works.sh \
src/roff/groff/tests/dvi-device-smoke-test.sh \
+ src/roff/groff/tests/error-close-request-given-empty-argument.sh \
src/roff/groff/tests/error-dt-request-given-bogus-arguments.sh \
src/roff/groff/tests/error-grief-token-descriptions.sh \
src/roff/groff/tests/error-mso-request-given-empty-argument.sh \
src/roff/groff/tests/error-no-space-between-dt-or-wh-arguments.sh \
src/roff/groff/tests/error-overflow-symbol-table.sh \
+ src/roff/groff/tests/error-pi-request-given-empty-argument.sh \
+ src/roff/groff/tests/error-pso-request-given-empty-argument.sh \
src/roff/groff/tests/error-so-request-given-empty-argument.sh \
+ src/roff/groff/tests/error-sy-request-given-empty-argument.sh \
src/roff/groff/tests/evc-request-produces-no-output-if-invalid.sh \
src/roff/groff/tests/fi-and-nf-requests-work.sh \
src/roff/groff/tests/fp-request-does-not-traverse-directories.sh \
diff --git a/src/roff/groff/tests/error-close-request-given-empty-argument.sh
b/src/roff/groff/tests/error-close-request-given-empty-argument.sh
new file mode 100755
index 000000000..34ea49dec
--- /dev/null
+++ b/src/roff/groff/tests/error-close-request-given-empty-argument.sh
@@ -0,0 +1,32 @@
+#!/bin/sh
+#
+# This file is part of groff, the GNU roff typesetting system.
+#
+# groff is free software; you can redistribute it and/or modify it under
+# the terms of the GNU General Public License as published by the Free
+# Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# groff is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+# for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+groff="${abs_top_builddir:-.}/test-groff"
+
+# Regression-test Savannah #68786 (in part).
+#
+# The `close` request should reject an empty argument sensibly (and
+# quietly, unless `-w missing`), not fail an assertion.
+
+input='.
+.ds a \" empty
+.close \*[a]
+.'
+
+output=$(printf '%s\n' "$input" | "$groff" -T ascii)
+
+# vim:set autoindent expandtab shiftwidth=4 tabstop=4 textwidth=72:
diff --git a/src/roff/groff/tests/error-pi-request-given-empty-argument.sh
b/src/roff/groff/tests/error-pi-request-given-empty-argument.sh
new file mode 100755
index 000000000..65074df16
--- /dev/null
+++ b/src/roff/groff/tests/error-pi-request-given-empty-argument.sh
@@ -0,0 +1,32 @@
+#!/bin/sh
+#
+# This file is part of groff, the GNU roff typesetting system.
+#
+# groff is free software; you can redistribute it and/or modify it under
+# the terms of the GNU General Public License as published by the Free
+# Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# groff is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+# for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+groff="${abs_top_builddir:-.}/test-groff"
+
+# Regression-test Savannah #68786 (in part).
+#
+# The `pi` request should reject an empty argument sensibly (and
+# quietly, unless `-w missing`), not fail an assertion.
+
+input='.
+.ds a \" empty
+.pi \*[a]
+.'
+
+output=$(printf '%s\n' "$input" | "$groff" -U -T ascii)
+
+# vim:set autoindent expandtab shiftwidth=4 tabstop=4 textwidth=72:
diff --git a/src/roff/groff/tests/error-pso-request-given-empty-argument.sh
b/src/roff/groff/tests/error-pso-request-given-empty-argument.sh
new file mode 100755
index 000000000..7e5181a9a
--- /dev/null
+++ b/src/roff/groff/tests/error-pso-request-given-empty-argument.sh
@@ -0,0 +1,32 @@
+#!/bin/sh
+#
+# This file is part of groff, the GNU roff typesetting system.
+#
+# groff is free software; you can redistribute it and/or modify it under
+# the terms of the GNU General Public License as published by the Free
+# Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# groff is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+# for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+groff="${abs_top_builddir:-.}/test-groff"
+
+# Regression-test Savannah #68786 (in part).
+#
+# The `pso` request should reject an empty argument sensibly (and
+# quietly, unless `-w missing`), not fail an assertion.
+
+input='.
+.ds a \" empty
+.pso \*[a]
+.'
+
+output=$(printf '%s\n' "$input" | "$groff" -U -T ascii)
+
+# vim:set autoindent expandtab shiftwidth=4 tabstop=4 textwidth=72:
diff --git a/src/roff/groff/tests/error-sy-request-given-empty-argument.sh
b/src/roff/groff/tests/error-sy-request-given-empty-argument.sh
new file mode 100755
index 000000000..e7e2bd4fc
--- /dev/null
+++ b/src/roff/groff/tests/error-sy-request-given-empty-argument.sh
@@ -0,0 +1,32 @@
+#!/bin/sh
+#
+# This file is part of groff, the GNU roff typesetting system.
+#
+# groff is free software; you can redistribute it and/or modify it under
+# the terms of the GNU General Public License as published by the Free
+# Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# groff is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+# for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+groff="${abs_top_builddir:-.}/test-groff"
+
+# Regression-test Savannah #68786 (in part).
+#
+# The `sy` request should reject an empty argument sensibly (and
+# quietly, unless `-w missing`), not fail an assertion.
+
+input='.
+.ds a \" empty
+.sy \*[a]
+.'
+
+output=$(printf '%s\n' "$input" | "$groff" -U -T ascii)
+
+# vim:set autoindent expandtab shiftwidth=4 tabstop=4 textwidth=72:
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
