gbranden pushed a commit to branch master
in repository groff.
commit 687d47650bf826a1f5b2858a5b13e11ad246c3e4
Author: G. Branden Robinson <[email protected]>
AuthorDate: Wed Oct 21 22:12:08 2026 -0500
[groff]: Improve `pi` request test.
* src/roff/groff/tests/pi-request-works.sh: Fail if groff exits with a
nonzero status, which happens if an ASAN-enabled build detects memory
untidiness. This enables us to detect problems like Savannah #68815.
---
ChangeLog | 7 +++++++
src/roff/groff/tests/pi-request-works.sh | 4 ++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 0d89ec621..655f9deac 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2026-10-21 G. Branden Robinson <[email protected]>
+
+ * src/roff/groff/tests/pi-request-works.sh: Improve test. Fail
+ if groff exits with a nonzero status, which happens if an
+ ASAN-enabled build detects memory untidiness. This enables us
+ to detect problems like Savannah #68815.
+
2026-10-18 G. Branden Robinson <[email protected]>
[troff]: Revise `rn` input validation.
diff --git a/src/roff/groff/tests/pi-request-works.sh
b/src/roff/groff/tests/pi-request-works.sh
index 454f46f1d..a85b04d7f 100755
--- a/src/roff/groff/tests/pi-request-works.sh
+++ b/src/roff/groff/tests/pi-request-works.sh
@@ -27,13 +27,13 @@ wail () {
}
echo "checking that 'pi' request works" >&2
-output=$(printf '.pi sed s/^/#/\nhello\n' | "$groff" -UZ)
+output=$(printf '.pi sed s/^/#/\nhello\n' | "$groff" -UZ) || wail
echo "$output"
echo "$output" | grep -Eqx '^#t *hello'
echo "checking that parser returns to correct state after 'pi'" >&2
output=$(printf '.pi cat\n.tm goodbye\n' \
- | "$groff" -UZ 2>&1 > /dev/null)
+ | "$groff" -UZ 2>&1 > /dev/null) || wail
echo $output
echo $output | grep -Fqx goodbye || wail
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
