gbranden pushed a commit to branch master
in repository groff.

commit 8bd665bcad25eacd3f2d295c5e6d34b2b190dd99
Author: G. Branden Robinson <[email protected]>
AuthorDate: Sun Nov 8 14:58:51 2026 -0600

    [troff]: Raise a ruckus on failed file/pipe close.
    
    * src/roff/troff/input.cpp (file_iterator::close): If basic operating
      system services are failing us, we want the user to know about it.
      Throw error diagnostic if fclose(3) or pclose(3) fail.
---
 ChangeLog                | 8 ++++++++
 src/roff/troff/input.cpp | 9 +++++++--
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index c6ceabc42..ecea890ae 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2026-11-08  G. Branden Robinson <[email protected]>
+
+       * src/roff/troff/input.cpp (file_iterator::close): Raise a
+       ruckus on failed closure of a file stream or pipeline.  If basic
+       operating system services are failing us, we want the user to
+       know about it.  Throw error diagnostic if fclose(3) or pclose(3)
+       fail.
+
 2026-11-08  G. Branden Robinson <[email protected]>
 
        * src/roff/troff/input.cpp (file_iterator::file_iterator): Drop
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 927168b89..bd23e0a3e 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -488,12 +488,17 @@ file_iterator::~file_iterator()
 
 void file_iterator::close()
 {
+  int ret = 0;
   if (fp == stdin)
     clearerr(stdin);
   else if (was_popened)
-    pclose(fp);
+    ret = pclose(fp);
   else
-    fclose(fp);
+    ret = fclose(fp);
+  if (ret != 0)
+    error("cannot close %1 \"%2\": %3", was_popened ? "pipe" : "file",
+         filename, strerror(errno));
+
 }
 
 bool file_iterator::next_file(FILE *f, const char *s)

_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit

Reply via email to