gbranden pushed a commit to branch master
in repository groff.
commit 02b59d5cd405c160aa3f7ae0adf25046cebbfb65
Author: G. Branden Robinson <[email protected]>
AuthorDate: Sun Nov 15 18:44:50 2026 -0600
src/preproc/pic/pic.ypp: Fix code style nits.
* src/preproc/pic/pic.ypp (reset, reset_all): Update definitions and
forward declarations to mark functions `static`, as they do not
require external linkage.
---
ChangeLog | 6 ++++++
src/preproc/pic/pic.ypp | 8 ++++----
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index a76e9cc81..b3041bfee 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2026-11-15 G. Branden Robinson <[email protected]>
+
+ * src/preproc/pic/pic.ypp (reset, reset_all): Fix code style
+ nits. Update definitions and forward declarations to mark
+ functions `static`, as they do not require external linkage.
+
2026-07-22 G. Branden Robinson <[email protected]>
[pic]: Partially migrate to strdup(3).
diff --git a/src/preproc/pic/pic.ypp b/src/preproc/pic/pic.ypp
index 0c0e8ed42..3a6b51038 100644
--- a/src/preproc/pic/pic.ypp
+++ b/src/preproc/pic/pic.ypp
@@ -61,8 +61,8 @@ extern "C" {
int yylex();
void yyerror(const char *);
-void reset(const char *nm);
-void reset_all();
+static void reset(const char *nm);
+static void reset_all();
place *lookup_label(const char *);
void define_label(const char *label, const place *pl);
@@ -1863,7 +1863,7 @@ void parse_init()
reset_all();
}
-void reset(const char *nm)
+static void reset(const char *nm)
{
for (size_t i = 0; i < countof(defaults_table); i++)
if (strcmp(nm, defaults_table[i].name) == 0) {
@@ -1879,7 +1879,7 @@ void reset(const char *nm)
lex_error("'%1' is not a predefined variable", nm);
}
-void reset_all()
+static void reset_all()
{
// We only have to explicitly reset the predefined variables that
// aren't scaled because 'scale' is not scaled, and changing the
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit