Hi Peter & Deri,

I noticed that the `-E` argument to a `.pdfhref L` call doesn't seem to
do anything.  I compared before-and-after, and while the PDF checksums
change, the file sizes do not.  I assume there is a shifty data
structure (like a hash table) or an embedded date stamp in the PDF that
changes.  I'd have more to report, but _pdfmom_ doesn't support groff's
`-Z` option.

Hyperlinks of various types, both internal (whether from tables of
contents or within body text) and external still work fine, and appear
to have correct link text.

Ok to push?

Regards,
Branden

* contrib/mom/om.tmac (PAD, TO_TOC, PDF_LINK): Arrange mandatory
  arguments before optional ones, and stop using nilpotent `-E`
  argument.
---
 contrib/mom/ChangeLog | 6 ++++++
 contrib/mom/om.tmac   | 8 ++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/contrib/mom/ChangeLog b/contrib/mom/ChangeLog
index 38386b3d7..c2c4bf12f 100644
--- a/contrib/mom/ChangeLog
+++ b/contrib/mom/ChangeLog
@@ -1,3 +1,9 @@
+2026-01-15  G. Branden Robinson <[email protected]>
+
+       * om.tmac (PAD, TO_TOC, PDF_LINK): Simplify `pdfhref` calls.
+       Arrange mandatory arguments before optional ones, and stop using
+       nilpotent `-E` argument.
+
 2025-12-31  G. Branden Robinson <[email protected]>
 
        * mom.am (EXTRA_DIST): Ship "COPYRIGHT" file in distribution
diff --git a/contrib/mom/om.tmac b/contrib/mom/om.tmac
index 859be53d1..32a988bce 100644
--- a/contrib/mom/om.tmac
+++ b/contrib/mom/om.tmac
@@ -2504,7 +2504,7 @@ .       defcolor \\$1  \\*[$COLOR_SCHEME] \\$3
 \f[\\*[$FONT_FOR_PAD]]\s[\\n[#SIZE_FOR_PAD]u]
 .    ie '\\$2'' .nop \\*[$PAD_STRING]
 .    el \{\
-.       ie !'\\$2'NOBREAK' .pdfhref L -D "\\$2" -E -- \&\\*[$PAD_STRING]
+.       ie !'\\$2'NOBREAK' .pdfhref L -D "\\$2" -- \&\\*[$PAD_STRING]
 .       el .nop \\*[$PAD_STRING]
 .    \}
 .    if \\n[#SILENT] .SILENT OFF
@@ -15937,7 +15937,7 @@ .       defcolor \\$1  \\*[$COLOR_SCHEME] \\$3
 \\n[#TOC_HEAD_\\n[#LEVEL]_INDENT]u+\
 \w'\\*[$TOC_HD_NUM]'u
 .          ti -\w'\\*[$TOC_HD_NUM]'u
-.          pdfhref L -D "\\*[PDFBOOKMARK.NAME]" -E -- \
+.          pdfhref L -D "\\*[PDFBOOKMARK.NAME]" -- \
 \&\\*[$TOC_HD_NUM]\\*[$TOC_HEAD_\\n[#LEVEL]_ITEM]
 \!.        ll
 '          in
@@ -15988,7 +15988,7 @@ .       defcolor \\$1  \\*[$COLOR_SCHEME] \\$3
 .             fam \\*[$TOC_TITLE_FAM]
 .             ft \\*[$TOC_TITLE_FT]
 .             in \\n[#TOC_TITLE_INDENT]u
-.             pdfhref L -D "\\*[PDFBOOKMARK.NAME]" -E -- \
+.             pdfhref L -D "\\*[PDFBOOKMARK.NAME]" -- \
 \&\\*[$TOC_TITLE_ITEM]
 \!.           ll
 '             in
@@ -23864,7 +23864,7 @@ .             defcolor pdf:href.colour rgb \\$1
 .            el .as PDF_TXT Unknown
 .       \}
 .    \}
-.    pdfhref L \\*[PDF_PRE] \\*[PDF_POST] -D \\*[PDF_NM] -- \\*[PDF_TXT]
+.    pdfhref L -D \\*[PDF_NM] \\*[PDF_PRE] \\*[PDF_POST] -- \\*[PDF_TXT]
 .    rm PDF_NM
 .    rm PDF_PRE
 .    rm PDF_POST
-- 
2.30.2

Attachment: signature.asc
Description: PGP signature

Reply via email to