Hi Phong, At 2026-11-06T11:34:12+0900, Nguyễn Gia Phong wrote: > On 2026-10-29 at 18:28-05:00, G. Branden Robinson wrote: > > groff 1.25.0 release candidate 4, 1.25.0.rc4, is now available from > > GNU's alpha site. You may download the distribution archive from > > there. > > Hi, there's a typo in src/roff/groff/tests/soquiet-request-works.sh > that caused the test to fail since its refactoring in 111c42a69abc; > s/doc/input/ should fix it.
Thanks for the report. I agree. The test is pretty thin stuff. I think I originally wrote it (back in 2021) only to make sure I didn't corrupt the state of the interpreter. Nowadays I understand the formatter's internals a bit better, but I also hope to turn `soquiet` into a macro, so I didn't expend any effort making the test more sensitive. On the same today I introduced the error you found, I added a new test script that _is_ more sensitive, so improving the one above would be redundant. commit 2eb2d11cedc3edcb755c7a00273e9533e9f8957d Author: G. Branden Robinson <[email protected]> Date: Fri Oct 16 16:44:34 2026 -0500 [groff]: Unit-test `so` request. * src/roff/groff/tests/so-request-works.sh: Do it. * src/roff/groff/tests/artifacts/sourced-file: New file. * src/roff/groff/groff.am: Update `groff_TESTS` to run test. Update `EXTRA_DIST` to ship new artifact file. > Otherwise, I'm happy to report that this RC builds fine on Guix. Excellent news! Thanks! Regards, Branden
signature.asc
Description: PGP signature
