Right, the grpc-java part got merged a little before the full system was ready since we could already test it out. Feel free to try out the compiler from the PR, though! The content is there and ready for folks to experiment with. In fact, I've approved the code, but haven't merged it yet because I want to make sure that the installation is truly seamless.
We'd appreciate any feedback that you have on it: it's still an early experimental version, but we'll move it forward as we get more users for it. Best regards, Vijay On Monday, August 15, 2016 at 10:59:13 AM UTC-7, Mathias Gruschinske wrote: > > Thank you for your reply! I haven't seen this pull request. I'm just > confused that the Apache Thrift integration for Java is already merged. > > On Monday, August 15, 2016 at 7:36:32 PM UTC+2, Vijay Pai wrote: >> >> Hello there, >> The compiler is still in code review pending a merge. You can see it at >> https://github.com/grpc/grpc/pull/7594 . We will eventually try to >> upstream this into Apache Thrift but for now it works by patching against >> an existing commit of Thrift. >> Best regards, >> Vijay >> >> >> On Sunday, August 14, 2016 at 6:17:10 AM UTC-7, Mathias Gruschinske wrote: >>> >>> Hi guys, >>> >>> if I am right, with the thrift integration pull request ( >>> https://github.com/grpc/grpc-java/pull/2023) came Apache Thrift support >>> but there isn't a official compiler/generator? >>> >>> I only found this repo https://github.com/chedeti/thrift with a grpc >>> generator. Is it planed to merge it with the official Apache Thrift repo? >>> There isn't any Jira issue or Pull Request to address it. >>> >>> -Mathias >>> >> -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/3c92e726-7b46-4de9-adab-742058dcee08%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
