The docs on grpc.io are also .md files! :) We're actually trying to move away from having docs in the repo and not on the site where possible as it means some useful info isn't as easy to find as it could be, but if it's not clear (yet) where this would fit, I'll review in its current location and we can move it if necessary.
On Thu, May 11, 2017 at 11:38 PM, Arpit Baldeva <[email protected]> wrote: > Hmm...the docs in the repo are in the .md format and as per the discussion > here(https://groups.google.com/forum/#!topic/grpc-io/DuBDpK96B14 ) , the > ask was to submit a PR in the .md format. > > I think it makes sense to go it in the repo as I see other similar docs > there too. As for the grpc.io itself, while I think the doc can go there > too, I am not sure about the process around it. > > The doc was written while working with C++ code base. I am unsure how much > of it translates to the other languages as I have no expertise with them. > > Thanks. > > On Thursday, May 11, 2017 at 2:01:40 PM UTC-7, Lisa Carey wrote: >> >> Actually I see why it slipped through the net, it's being submitted to >> grpc/doc rather than grpc.github.io, which is where I look out for doc >> PRs. >> >> Is this appropriate for grpc.io (it looks v useful) rather than just the >> repo, and is it C++ specific or applicable to any language version that >> comes in sync and async flavours? >> >> On Thu, May 11, 2017 at 9:55 PM, Lisa Carey <[email protected]> wrote: >> >>> Sure, I'll take a look and sorry it took me a while to get to, I think >>> it slipped through the net because the CLA hadn't been verified. Will get >>> back to you with review comments ASAP. >>> >>> On Thu, May 11, 2017 at 7:12 PM, Varun Talwar <[email protected]> >>> wrote: >>> >>>> Assigned to Lisa who can help review and merge the docs. >>>> >>>> >>>> On Thu, May 11, 2017 at 11:09 AM, Arpit Baldeva <[email protected]> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> Is there any recommended process to get the PR approved and merged? I >>>>> submitted a PR a while back (https://github.com/grpc/grpc/pull/10919 >>>>> ) and it is still waiting for a reviewer and CLA verification. I am also >>>>> unsure how to select/assign a person as the reviewer. >>>>> >>>>> Thanks. >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "grpc.io" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To post to this group, send email to [email protected]. >>>>> Visit this group at https://groups.google.com/group/grpc-io. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/grpc-io/3b506a2c-008b-4cdb >>>>> -9340-d4c16e7a3205%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/grpc-io/3b506a2c-008b-4cdb-9340-d4c16e7a3205%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> >>>> >>>> -- >>>> Varun Talwar | Product Manager | [email protected] | 415-341-7352 >>>> >>>> >>>> >>> >>> >>> -- >>> Google Ireland Ltd. : Registered in Ireland with company number 368047. >>> Gordon House, Barrow Street, Dublin 4, Ireland. >>> >> >> >> >> -- >> Google Ireland Ltd. : Registered in Ireland with company number 368047. >> Gordon House, Barrow Street, Dublin 4, Ireland. >> > -- Google Ireland Ltd. : Registered in Ireland with company number 368047. Gordon House, Barrow Street, Dublin 4, Ireland. -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/grpc-io. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/CACGvD08e663qZB5YhRdeyiz0Yc0hRvtsUjEvASMNCZJ_VarrOg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
