On Mon, Aug 28, 2017 at 7:18 AM Evan Jones <[email protected]> wrote:
> We are mostly a mono-repo, for the reasons you mentioned. However, we have > I think two other random services that don't quite work that way. For those > ones, we currently copy .proto files into their own repo, and hope to > remember to do this whenever we change them. We have zero tools or > automation around this. For the moment, it hasn't been a problem, since we > don't change the .proto definitions THAT often, and more importantly: it is > very rare that we change them in a backwards-incompatible fashion. > > That said: our longer term goal is to put everything in a single > repository so this problem goes away. > > Thanks for sharing, Evan. > Hope that helps, > > Evan > > > On Sunday, August 27, 2017 at 5:19:33 AM UTC-4, Amit Saha wrote: >> >> Hello all, >> >> When we have multiple services and want to share common messages, I guess >> the simple approach is a mono repo of the proto definitions. One definite >> con that we currently face (with Thrift definitions) is gate keeping the >> mono repo (who can push for example). This also means that we cannot let >> all service maintainers to just push to this repo. However, the pro is we >> don't have to use "git submodules" or another approach for using shared >> definitions. >> >> Is there a "best practice" that has emerged and would be recommended? >> >> Thanks, >> Amit. >> > -- > You received this message because you are subscribed to a topic in the > Google Groups "grpc.io" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/grpc-io/T4TGB5uyGNQ/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/grpc-io. > To view this discussion on the web visit > https://groups.google.com/d/msgid/grpc-io/29f0954a-9ecf-4f1c-8fe6-d4b984877e68%40googlegroups.com > <https://groups.google.com/d/msgid/grpc-io/29f0954a-9ecf-4f1c-8fe6-d4b984877e68%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/grpc-io. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/CANODV3k5XPA0hDrP6QjYATL2W3w1g4DNMQj3J-pk_NzcLF0mmg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
