I've sent out https://github.com/grpc/grpc/pull/12523 to fix it. Thanks for filing this issue!
On Tuesday, September 12, 2017 at 4:17:33 PM UTC-7, Vijay Pai wrote: > > Yes, I think you're right. There could certainly be cases where you would > use IDLE without caring about AGE. > > On Friday, August 11, 2017 at 3:31:42 PM UTC-7, Arpit Baldeva wrote: >> >> Hi, >> >> The server side gRFC - >> https://github.com/ejona86/proposal/blob/a339b01be9eafffb1adc4db8c782469caed18bdc/A9-server-side-conn-mgt.md >> >> - does not mention that both connection age and connection idle need to be >> specified together. So shouldn't the following code use an || instead of &&? >> >> static bool maybe_add_max_age_filter(grpc_exec_ctx* exec_ctx, >> grpc_channel_stack_builder* builder, >> void* arg) >> bool enable = >> grpc_channel_arg_get_integer( >> grpc_channel_args_find(channel_args, >> GRPC_ARG_MAX_CONNECTION_AGE_MS), >> MAX_CONNECTION_AGE_INTEGER_OPTIONS) != INT_MAX* &&* >> grpc_channel_arg_get_integer( >> grpc_channel_args_find(channel_args, >> GRPC_ARG_MAX_CONNECTION_IDLE_MS), >> MAX_CONNECTION_IDLE_INTEGER_OPTIONS) != INT_MAX; >> >> I can see use of setting one without the other. >> >> Thanks. >> > -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/grpc-io. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/57b6b07b-8834-4526-bccc-3e41dffe788a%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
