> > General comments on the proposal are preferred here. Comments that are > tied to on the implementation are probably easier addressed on the pull > request of the implementation, i.e. > https://github.com/grpc/grpc/pull/12613 > > 1. The proposal talks about adding an Items dictionary for interceptors' satellite data. What types are thought for the key and value? A string -> object map? (I skimmed the implementation, and I think this is actually being dropped for the first version due to multi-thread access concerns.)
2. It seems implied that an interceptor can manipulate the request or response objects. Yet, the interfaces are all generic. Is an explicit is/as check/cast expected if an interceptor wants to look at the actual payloads? (Kinda "in other words": I don't see a way to register an interceptor for a specific "Foo" method with concrete types where I get an actual FooRequest object instead of TRequest.) 3. It looks like the server-side interceptors all are invoked after unmarshalling has been performed. If I wanted to write a RejectRequestsIfServiceOverloadedInterceptor that fails requests, it would be better if I didn't have to unmarshall the payloads just to reject them. Though, I'm not sure if this is enough motivation for having to deal with the extra complication of having interceptors injected at different places in the lifetime of a call... 4. I'm confused by the section starting with "the class provides a few static methods that lets the interceptor register additional hooks to execute code when certain events happen in asynchronous and streaming calls", particularly by the set of static protected methods that come after it. I'm not sure what type these live in or who would override them. Can you demonstrate/point to in the implementation PR an example of how these would be used? -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/grpc-io. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/852bd664-db54-4c61-9303-00ba886c6314%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
