My wording was ambiguous, but what I meant to ask was whether the framework guarantees that ServerCall::close will be called on the possibly-wrapped-by-interceptors ServerCall passed on to the next handler. Our logs suggest that it does not.
Our logging interceptor wasn't logging in the returned ServerCall.Listener's onCancel and onCompleted callbacks, so I suspect that in some cases of connection issues, there's an onCancel callback and no call to the interceptor-supplied ServerCall::close. We'll add logging there are see what we see. On Monday, October 30, 2017 at 7:49:50 PM UTC-5, Carl Mastrangelo wrote: > > You should always call close, except if it has already been closed. You > can tell if a downstream interceptor has called close because you will get > back an onCancel or onComplete callback from the ServerCall.Listener you > get back from ServerCallHandler.startCall. > -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/grpc-io. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/1e19c923-d825-4019-9361-eb0e8f099d58%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
