I view the following as an interesting one. host_port.h provides two utility functions for name management: gpr_join_host_port and gpr_split_host_port . Both are used in several places inside core. They are also used in the core and C++ tests. So those are still fine with privatizing.
However, gpr_join_host_port is also used in the objective-C tests. Only in the tests, not at all in the implementation. And, as it turns out, those tests already dip into src/core in their includes. Thus, I'm going to say that host_port.h is privatizable even though objective-C nominally uses it. If objective-C later moves to its own repo, it will already have to deal with the privatized headers issue for testing anyway. - Vijay -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/grpc-io. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/31edfbcb-d0b8-4f34-acee-8cb2a39df929%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
