A few observations on the proposal (especially when seen from the C++ side)
-
1. When client receive a RST_STREAM, a GOAWAY, deadline expires, the
connection breaks or any similar error condition -
- A fake status message is generated. The status_details reflect the
error with which the RPC failed.
- The documentation should be changed accordingly, or made less
stringent that the trailers are what were actually received from the wire.
2. C++ allows the server to cancel. It differs from the other platforms
on this and it probably shouldn't be able to do this, but it is the current
ground truth, which means the server can also log EVENT_CANCEL.
- This is fine, since the current documentation does not disallow the
server to log EVENT_CANCEL.
3. The client can initiate a Cancel but still receive the status from
the server before the Cancel actually takes affect.
- In this case, implementations should log the server trailers since
that is how the RPC actually ended.
- Since this is inherently racy, it should be fine for tools to be
slightly imprecise.
On Tuesday, August 28, 2018 at 5:32:37 PM UTC-7, [email protected] wrote:
>
> Please use A19 instead
>
> On Tuesday, August 28, 2018 at 4:44:16 PM UTC-7, [email protected]
> wrote:
>>
>> Correction: the title will be A18, not A16.
>>
>> On Tuesday, August 28, 2018 at 4:43:09 PM UTC-7, [email protected]
>> wrote:
>>>
>>> There is a gRFC describing the design of binary logging for gRPC, and
>>> feedback is welcome. The log events describe what the application sees for
>>> an RPC.
>>> https://github.com/grpc/proposal/pull/41
>>>
>>> Please keep the discussions on this thread. Thanks!
>>>
>>
--
You received this message because you are subscribed to the Google Groups
"grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/grpc-io.
To view this discussion on the web visit
https://groups.google.com/d/msgid/grpc-io/49fd0fd8-33b9-4de3-962c-133e3f26a36b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
