Sounds good. I'll follow up with another PR with those corrections. Thanks for the review.
On Tuesday, March 10, 2020 at 2:16:44 PM UTC-7 [email protected] wrote: > On Tuesday, March 10, 2020 at 1:33:52 PM UTC-7, Moiz Haidry wrote: > > MH> There is a note in the proposal under grpc plugin credentials > mentioning > MH> that this a breaking API change. Please let me know if there needs to > be > MH> more details provided. > > The proposal has this: > > > The caller has to initialize the method if they plan to use the > > debug_string method. > > This note looks pretty good to me, though I'd reword this so that there’s > no > implication that it's OK for the field to be uninitialized. How about this? > > "The caller must initialize this field to either NULL or an implementation > of the debug_string callback." > > While the current implementation may be fine with an uninitialized field, > if > I remember by C undefined behavior rules correctly, I think that operations > like copying the struct may result in undefined behavior should > debug_string > remain uninitialized. > > > -- > Christopher Warrington > Microsoft Corp. > > -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/d233771a-ddff-4d89-b96b-dd42561a9170%40googlegroups.com.
