I am happy to contribute the change to gRPC. I will put up a RFC first and we can iterate on that. However, I am new to github and grpc, so it may take me some time to finish it. I don't want to block other people because of my slowness. Do you have an ETA of this feature in mind?
btw, we have initiated a discussion https://github.com/grpc/grpc-go/issues/2827 last year in grpc-go. I can work on core and Go. On Mon, Aug 3, 2020 at 10:06 AM Mark D. Roth <[email protected]> wrote: > We've talked about doing something like this. You will need a way to > store the endpoint weight in the ServerAddress, but we don't want to add a > top-level field for this. Instead, I've thrown together > https://github.com/grpc/grpc/pull/23716 to give you a mechanism to do > this. > > Also, note that neither the C-core LB policy API nor the XdsClient API are > currently public APIs, which means that you'll probably need to contribute > this new LB policy to gRPC instead of maintaining it separately. And since > this is functionality that will probably also be desired in Java and Go, I > suggest writing a gRFC <https://github.com/grpc/proposal/> for how this > will work, so that anyone who implements it in those languages later will > be able to build a compatible implementation. > > If you'd like to talk further about how this needs to work, please let me > know. Good luck! > > On Sun, Aug 2, 2020 at 12:09 AM [email protected] <[email protected]> > wrote: > >> Hey folks, >> >> I am looking into implementing getting this information from eDS response >> and weighted round robin policy with edf scheduling picker. I am new to >> grpc codebase. Please help me on following question. >> >> I found the easiest way to pass information to picker is adding a field >> "lb_weight" to ServerAddress >> (src/core/ext/filters/client_channel/server_address.h). does it sound good? >> or any other suggestions? >> >> yishu >> >> -- >> You received this message because you are subscribed to the Google Groups >> "grpc.io" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/grpc-io/102fffee-9733-4d89-afe2-c25a10594de8n%40googlegroups.com >> <https://groups.google.com/d/msgid/grpc-io/102fffee-9733-4d89-afe2-c25a10594de8n%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > > > -- > Mark D. Roth <[email protected]> > Software Engineer > Google, Inc. > -- 戴翊書 Yi-Shu Tai M.S. UCSD CS 2017 -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/CAK%2B0oQGGCFxwfw5dGNrG578MhMgFZNuVkwuEtfDF7GMEKdPu4g%40mail.gmail.com.
