Ok I understand the point but I missed some details: - I can fork grpc to my github account but how to give it to the grpc-ecosystem ? - For adding libusb dependency, am I obliged to go through third_party git submodule and compile libusb from sources ? Or can I only relies on system package (if so , where do I put it, directly in CMakeLists.txt) ? - I have only a test setup running on unix , will it be acceptable for this fork to be only unix compatible ? Or do I need to support windows, apple ... ?
Thanks again for your quick answer by the way. Have a nice day ! On Friday, 26 February 2021 at 04:12:32 UTC+1 [email protected] wrote: > Hi, > > While the idea is interesting and has merit, adding a libusb dependency > into a network-oriented library seems counter productive and would likely > complexify our build, test, distribution, and maintenance burden. This > seems like an endeavor that'd be much more appropriate as a specific fork; > call it grpc-usb if you want, and it'd ONLY have USB as a transport > mechanism. We wouldn't mind hosting it in our grpc-ecosystem organization > for instance. > > On Thu, Feb 25, 2021 at 8:35 AM Frédéric Martinsons < > [email protected]> wrote: > >> Hello guys, like I said in a previous message ( >> https://groups.google.com/g/grpc-io/c/rCOTPM65A7U) , back in the day, in >> my company there was a use cases to having gRPC work through usb. We made >> patches for that and we would like to submit it to the project. >> >> Two questions though: >> - Is is wanted and will it be acceptable for the project (does it worth >> the shot to rebase and clean ourpatches) ? >> - If yes, then our patches introduced a libusb dependency ( >> https://libusb.info/) and I'm wondering what is the best way to >> introduce that ? In a new third party submodule ? Is there documentation >> about integrating a new submodule because I read >> https://github.com/grpc/grpc/blob/master/third_party/README.md and there >> is not much details except that it trigs a lot of work and maintenance. >> >> Thanks in advance for all the insights. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "grpc.io" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/grpc-io/a0f856e9-dc0d-4f5f-82f1-ee2efef6ecd3n%40googlegroups.com >> >> <https://groups.google.com/d/msgid/grpc-io/a0f856e9-dc0d-4f5f-82f1-ee2efef6ecd3n%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/634fd52a-e24b-4959-9fad-fa4a4e2080c3n%40googlegroups.com.
