If validator.validate() and service.purge() can throw, then you want a try-catch. You must call onCompleted() or onError() on the observer for the RPC to complete (and thus release its memory). gRPC does have some handling for exceptions thrown by the service method, but it is a worst-case backup. It will respond with Status.UNKNOWN and interceptors might get confused.
If you are very concerned, you can catch exceptions from onNext(). In general code tends to assume onNext() won't throw (or rather, won't throw randomly; it will totally throw if you use it incorrectly, like calling it after onCompleted()). So that's why the Hello World example server doesn't have a try-catch. On Thu, Apr 11, 2024 at 1:55 PM Debraj <[email protected]> wrote: > If I have a code like below on a Java-based gRPC service > > @Override > public void purge( > final PurgeRequest request, final StreamObserver<PurgeResponse> > responseObserver) { > validator.validate(request); > responseObserver.onNext(service.purge(request)); > responseObserver.onCompleted(); > } > > Is it recommended that I catch the exception and call onError() like below > or it is not recommended? Is there any advantage of one approach over the > other? > > @Override > public void purge( > final PurgeRequest request, final StreamObserver<PurgeResponse> > responseObserver) { > try { > validator.validate(request); > responseObserver.onNext(gdprService.purge(request)); > responseObserver.onCompleted(); > } catch (final Exception e) { > log.error("Failed to purge {}", request, e); > responseObserver.onError(e); > } > } > > > -- > You received this message because you are subscribed to the Google Groups " > grpc.io" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/grpc-io/985e6aee-2de0-4ca4-b99e-f17e61297cc5n%40googlegroups.com > <https://groups.google.com/d/msgid/grpc-io/985e6aee-2de0-4ca4-b99e-f17e61297cc5n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "grpc.io" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/CA%2B4M1oPa2ieyMp%2BSW%3DwtjH4Kuuw1vxmxVEKiLRYr2JROzUNwHw%40mail.gmail.com.
smime.p7s
Description: S/MIME Cryptographic Signature
