On Wednesday 20 July 2005 01:01, Ruslan Nikolaev wrote: > > I agree. This is more readable. > > I can change it of course... But it is not so bad:
Well, I think the problem is that there is no meaning to use a union here, and it makes the function too long. > Ok... But first I have a question about grub2. Does it really provide > "mmap" information for OS as multiboot defined or memory size only? As this is written in the comment, this is not implemented yet. > As for 4Gb limit: > > 1. Memory size variable is a 32-bit. It measures in bytes => max 4Gb. > When it passes to OS it converts to KB measuring but it's still truncated > to 4Gb. But this itself is not a bug really. Because mem_upper is the size of a contiguous region starting from 1MB, and every BIOS has one or more memory holes before 4GB. Well, there is a 4GB limit. We must implement memory map passing. > 2005-07-17 Ruslan Nikolaev <[EMAIL PROTECTED]> > > * multiboot.c (grub_rescue_cmd_multiboot): using ELF64 loading code if > ELF CLASS is a 64-bit and CPU CLASS is X86_64 Please look at the examples carefully. The rule is the same as C comments: Also, please write complete sentences and capitalize the first word. If a lower-case identifier comes at the beginning of a sentence, don't capitalize it! Changing the spelling makes it a different identifier. If you don't like starting a sentence with a lower case letter, write the sentence differently (e.g., “The identifier lower-case is ...”). Okuji _______________________________________________ Grub-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/grub-devel
