On Saturday 22 October 2005 01:46 am, Timothy Baldwin wrote: > > I think it is better to define grub_off_t as grub_uint64_t, and use > > grub_off_t. > > Misleading as POSIX uses off_t as a byte offset. Also grub_off_t would be > logical type name for file offsets, which should use a separate type to aid > changing it.
I disagree. The development environment of GRUB was created to be intentionally similar to POSIX. For example, look at the usage of grub_size_t. It is rather convenient that one can guess how to program in GRUB based on an experience on POSIX. > Also grub_off_t is used in kern/mm.c to count bytes of memory. What is bad? Okuji _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel