Omniflux <[EMAIL PROTECTED]> writes: Hi,
Thanks a lot for your patch! > terminfo-definition-support.diff > * term/terminfo.c: Replaced static vt100 definition with user > definable definition support. > * include/grub/terminfo.h (grub_terminfo_get_current): Removed. > (grub_terminfo_set_current): Likewise Is it possible to do this in a GRUB env. variable, like: set TERM=vt100 And perhaps one variable or function to set the possible terminal descriptions. I think that would be easier for the user to do it this way. > As with the previous serial patch, some code here is based on the > terminfo support from GRUB Legacy. Any mistakes, however, are mine. :) > > I would appreciate comments and suggestions, especially for the short > parameter selection for the reverse video and cursor options. > > I tried not using a short parameter, but state[x].set does not get set > in that case, or I tried incorrectly. Sure, I'll look at this code after the weekend. The feedback I will give will be more useful than the feedback above... Can you provide a ChangeLog entry so the patch can be reviewed and applied? See the GNU Coding Standards (GCS) for information about how to write a changelog entry. If you have questions about this, feel free to contact me. > Also can someone point me to instructions for creating a menu so that > I may test other then the command line? At the moment I am working on the menu code, so the syntax will be changed really soon. But at the moment you can do something like: title foo linux /vmlinux ... title bar ... Thanks, Marco _______________________________________________ Grub-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/grub-devel
