On Mon, Oct 01, 2007 at 09:43:27PM +0200, Marcin Kurek wrote: > Hell[o] > > > Is this a bitmask? In this case, looks like you aren't using the right > > numbers. Now GRUB_TERM_SIMPLE_MENU == GRUB_TERM_DUMB | GRUB_TERM_NO_EDIT > > OTOH if that's what you intended, I think it's better to build one macro > > using the others. > > Eeeek, why ? The flags are checked using 'flags & <flag>' as I can see > in kern/term.c, then how (1 << 3) can be evaluated as (1 << 1) and (1 > << 2) in this case ?
Oops, sorry. That was an oversight. (why does it jump directly from 4 to 16??). > > This part doesn't look right. vesa/vga is a whole different history. At > > the > > least vesa *does* support unicode. > > But both remaps border codes to cp437 and my code change only this > part, the unicode support is still there I does not touch it. Oh, that's odd. I thought it would be using utf-8 directly. > > Have you verified that grub-emu still builds / works? > > It does not build for ieee1275 on cvs because missing util/hostfs.c in > powerpc-ieee1275.rmk, but after adding it builds/runs fine. Fixed, thanks. -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What use is a phone call, if you are unable to speak? (as seen on /.) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
