Robert Millan wrote: > On Wed, Oct 17, 2007 at 09:17:54PM +0300, Vesa Jääskeläinen wrote: >> Robert Millan wrote: >>> This patch splits the i386-generic part of i386/pc/loader.h into >>> i386/loader.h. >>> >>> Comments? >> Why did you move stuff from i386/pc to i386 ? >> >> I do see a point on running grub2 on non-pc i386... > > It's for LinuxBIOS. >
If this is some new arch that will be supported on i386 then I would suggest i386/linuxbios/. I think the question to be asked here is that does all i386 architectures need this functionality that you extracted. I have nothing against modularizing code, in example if you compare contents of the efi and pc directories you will notice that efi does not need most of the stuff that is present on pc. Actually I think better name for pc would be pcbios... If you want to share code with LinuxBIOS why not just share those files located on i386/pc/. _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
