Robert Millan wrote:
> CVSROOT: /sources/grub
> Module name: grub2
> Changes by: Robert Millan <robertmh> 07/11/06 21:23:59
>
> Modified files:
> . : ChangeLog
> term/i386/pc : serial.c
>
> Log message:
> 2007-11-06 Robert Millan <[EMAIL PROTECTED]>
>
> * term/i386/pc/serial.c (serial_hw_put): Switch order of
> arguments
> in grub_outb() calls.
> (serial_hw_init): Likewise.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/grub2/ChangeLog?cvsroot=grub&r1=1.437&r2=1.438
> http://cvs.savannah.gnu.org/viewcvs/grub2/term/i386/pc/serial.c?cvsroot=grub&r1=1.4&r2=1.5
Why on earth those parameters are reversed anyway :) ?
On all systems that I can remember arguments for lots of things go like
this:
func(destination, source)
examples are:
memcpy, strcpy
On most of the other systems outp is also outp(port, value)
("destination, source"). Eg. following the same convention.
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
