Robert Millan <[EMAIL PROTECTED]> writes: > On Fri, Nov 09, 2007 at 04:33:47PM +0100, Marco Gerards wrote: >> Robert Millan <[EMAIL PROTECTED]> writes: >> >> > This should make the error much clearer when partition exceeds 2 TiB on a >> > PC >> > partition map (currently, all user gets is a "out of partition" error which >> > is hard to figure out if you're unaware of the 2 TiB limit). >> > >> > Comments? >> >> See below :-) >> >> > -- >> > Robert Millan >> > >> > <GPLv2> I know my rights; I want my phone call! >> > <DRM> What use is a phone call, if you are unable to speak? >> > (as seen on /.) >> > >> > >> > * include/grub/types.h (ULONG_MAX32): New macro. >> > (ULONG_MAX64): Likewise. >> > (ULONG_MAX): Use ULONG_MAX32 / ULONG_MAX64 to define it. >> >> Please call use a GRUB_* prefix. >> >> > * util/misc.c (grub_util_warn): New function. >> > >> > * util/biosdisk.c (grub_util_biosdisk_get_grub_dev): Issue a warning >> > when `disk->total_sectors' exceeds ULONG_MAX32 on `pc' partmap. >> >> Why a warning and not an error? Or perhaps another part of GRUB >> should return an error? > > Uhm. The person who reported this later told me that the partmap was in fact > not `pc' but `gpt'. The problem this patch intended to address may still > apply, but without reproducing it first, I'd prefer not to run the risk of > "fixing" something that wasn't broken.
Ok, fine for me. Please don't forget to add the GRUB_ prefix before committing :-) -- Marco _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
