On Fri, 08 Feb 2008 20:15:39 +0100, Robert Millan wrote: > On Fri, Feb 08, 2008 at 06:44:26PM +0000, Sam Morris wrote: >> >> While that works, the output looks like this: >> >> Entering rescue mode... >> error: out of disk >> > _ >> >> Which does not present the information in the clearest possible way: it >> looks like the error happened in the rescue mode code, instead of the >> normal mode code. >> >> Also, the error message could be lost if any of the code between the >> start of grub_enter_rescue_mode and its call to grub_print_error itself >> triggers an error. >> >> For these reasons I think it's better to call grub_print_error from >> within grub_load_normal. > > Agreed. See attached patch. Does this work as expected ?
Yes, it works fine. -- Sam Morris http://robots.org.uk/ PGP key id 1024D/5EA01078 3412 EA18 1277 354B 991B C869 B219 7FDB 5EA0 1078 _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
