I've been testing GRUB using the serial terminal and noticed that there was no cursor (and that my terminal window also lost its cursor after running GRUB). I looked into this today and found that the escape sequences for turning the cursor on and off were the wrong way round. The attached patch fixes this so that the serial terminal now has a cursor :-)
Michael -- http://michael.gorven.za.net PGP Key ID 6612FE85 S/MIME Key ID D33AEB31
diff -rN -u old-grub-devel/ChangeLog new-grub-devel/ChangeLog
--- old-grub-devel/ChangeLog 2008-05-31 16:31:29.000000000 +0200
+++ new-grub-devel/ChangeLog 2008-05-31 16:31:29.000000000 +0200
@@ -1,3 +1,8 @@
+2008-05-31 Michael Gorven <[EMAIL PROTECTED]>
+
+ * term/terminfo.c (grub_terminfo_set_current): Correct vt100 cursor
+ on and off sequences.
+
2008-05-31 Robert Millan <[EMAIL PROTECTED]>
* util/update-grub_lib.in: Replace `grub-probe' with `${grub_probe}'.
diff -rN -u old-grub-devel/term/terminfo.c new-grub-devel/term/terminfo.c
--- old-grub-devel/term/terminfo.c 2008-05-31 16:31:29.000000000 +0200
+++ new-grub-devel/term/terminfo.c 2008-05-31 16:31:29.000000000 +0200
@@ -98,8 +98,8 @@
term.cls = grub_strdup ("\e[H\e[J");
term.reverse_video_on = grub_strdup ("\e[7m");
term.reverse_video_off = grub_strdup ("\e[m");
- term.cursor_on = grub_strdup ("\e[?25l");
- term.cursor_off = grub_strdup ("\e[?25h");
+ term.cursor_on = grub_strdup ("\e[?25h");
+ term.cursor_off = grub_strdup ("\e[?25l");
return grub_errno;
}
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
