On Wed, Jul 23, 2008 at 09:13:58PM -0400, Pavel Roskin wrote: > On Wed, 2008-07-23 at 19:52 -0500, David Fries wrote: > > > This calls the getshiftflags BIOS int 16h function 2 in startup.S, to > > find out the status of the shift and control keys (among others). The > > required header and source files were modified to expose > > grub_getshiftflags. menu.c checks grub_getshiftflags and will disable > > the timeout. > > Cannot we avoid adding code to core.img that it not called from > core.img? Just because it's written in assembly it doesn't mean it > should be in the in the core.
I could make the argument that it is ten assmebly instructions, but I think the stronger case is the other two keyboard reading routines are right there in the same file. I suppose the grub_checkkey and the new grub_getshiftflags could both be moved out of core.img, but where would they go and how would they get assigned to the grub_term structure? > Sure, we are better off now that we are using lzma, but it we start > adding stuff mindlessly, core.img can again grow too large for some > setups. > > -- > Regards, > Pavel Roskin > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- David Fries <[EMAIL PROTECTED]> http://fries.net/~david/ (PGP encryption key available) _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
