On Wed, Jul 30, 2008 at 05:11:24PM +0200, Felix Zielcke wrote: > Index: disk/raid.c > =================================================================== > --- disk/raid.c (Revision 1753) > +++ disk/raid.c (Arbeitskopie) > @@ -75,8 +75,10 @@ > grub_disk_memberlist_t list = NULL, tmp; > unsigned int i; > > - for (i = 0; i < array->total_devs; i++) > + for (i = 0; i < GRUB_RAID_MAX_DEVICES; i++)
The existing code is confusing. What is total_devs for? If we need to iterate up to 32, sounds like this variable is pointless? If it's useless, it should be removed (but maybe it isn't!). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
