On Tue, 05 Aug 2008 13:23:11 +0200 Marco Gerards <[EMAIL PROTECTED]> wrote:
> Hi Javier, > > Javier Martín <[EMAIL PROTECTED]> writes: > > While tools like `svn diff' can help in these kind of problems, > > their utility is greatly diminished if the offending change is part > > of a multi-line change. Besides, sometimes checks like "if (a=b)", > > or more frequently "if (a=f())" are intentionally used in C, so the > > error might become even more difficult to spot and correct. I ask > > for a deep reflection on this issue: maybe I'm dead wrong and an > > arrogant brat in my attempt to tackle the Holy GNU Coding > > Standards, but I'd like to ask input from more people on this. > > I will refuse patches with "if (a = f())", if that makes you sleep > better ;-) Since that will generate a gcc warning, I hope that the author would at least do if ((a = f ())) to indicate to gcc that you mean what you said. Regards, Colin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
