Hello, When I did the Home/End keys patch I noticied that in normal/menu.c there was some magic numbers (and some constants was already defined, in include/grub/term.h (actually, reading the ChangeLog was committed by Robert Millan on 2008-02-05)
I'm sending a patch to change the magic numbers by constants. ChangeLog: -------- 2008-08-17 Carles Pina i Estany <[EMAIL PROTECTED]> * menu/normal.c (run_menu): Change magic numbers by constants. -------- Thanks, PS: thanks Felix for committing the previous patch -- Carles Pina i Estany GPG id: 0x17756391 http://pinux.info
Index: normal/menu.c =================================================================== --- normal/menu.c (revision 1815) +++ normal/menu.c (working copy) @@ -421,7 +421,7 @@ print_entries (menu, first, offset); break; - case 16: + case GRUB_TERM_UP: case '^': if (offset > 0) { @@ -438,7 +438,7 @@ } break; - case 14: + case GRUB_TERM_DOWN: case 'v': if (menu->size > first + offset + 1) {
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel