On Fri, 2009-01-23 at 10:51 +0100, Daniel Mierswa wrote: > Am 01/21/09 18:30, Pavel Roskin schrieb: > > The patch looks good to me. I would split changes to commands/search.c > > into a separate commit. > > > > Please provide ChangeLog entries for the patches. > > > I will comply. Thanks for your quick response.
I'll appreciate if you write your Changelog entries according to the GNU coding standards. In particular, please don't abbreviate function names. > 2009-01-23 Daniel Mierswa <impu...@impulze.org> > * commands/search.c: caseless UUID comparing We have a very similar function search_fs_uuid() in disk/fs_uuid.c, and it still uses grub_strcmp(). Should it be using grub_strcasecmp() as well? Can we export that function to reuse it in commands/search.c? -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
