On Sat, Mar 14, 2009 at 06:52:55PM +0100, phcoder wrote: > Robert Millan wrote: >> On Sat, Mar 14, 2009 at 12:35:09AM +0100, phcoder wrote: >>> Index: conf/i386-ieee1275.rmk >>> =================================================================== >>> --- conf/i386-ieee1275.rmk (revision 2030) >>> +++ conf/i386-ieee1275.rmk (working copy) >>> @@ -126,10 +126,12 @@ >>> # For _multiboot.mod. >>> _multiboot_mod_SOURCES = loader/ieee1275/multiboot2.c \ >>> + loader/i386/multiboot_helper.S \ >> >> multiboot_helper.S is not being used on i386-ieee1275 AFAICT > > How can it be if multiboot.c is the same for pc and ieee1275?
$ grep multiboot.c conf/*.rmk conf/i386-coreboot.rmk:_multiboot_mod_SOURCES = loader/i386/multiboot.c \ conf/i386-pc.rmk:_multiboot_mod_SOURCES = loader/i386/multiboot.c \ >> grub_dl_unload_all() just disappeared. Is this intentional? I >> tend to agree that grub_dl_unload_all() is a waste of time, but >> this should be discussed separately. > > It is intentional because multiboot_real_boot is now in a module so we > can't unload it Ok then, I'm fine with disabling the unload. What does everybody else think? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel