1) Window save was done wrongly, but no matter we don't even
need to allocate a register window for such a simple routine,
there are enough registers available to do this
2) 'flush' operates on at least 8 bytes at a time, as defined
by V9, so 8 byte align the extremities of the region and
iterate 8 bytes at a time
2009-04-01 David S. Miller <da...@davemloft.net>
* kern/sparc64/cache.S: Fix grub_arch_sync_caches implementation.
---
kern/sparc64/cache.S | 26 ++++++++++++--------------
1 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/kern/sparc64/cache.S b/kern/sparc64/cache.S
index 2ebb693..1a16add 100644
--- a/kern/sparc64/cache.S
+++ b/kern/sparc64/cache.S
@@ -1,7 +1,7 @@
/* cache.S - Flush the processor cache for a specific region. */
/*
* GRUB -- GRand Unified Bootloader
- * Copyright (C) 2005,2007 Free Software Foundation, Inc.
+ * Copyright (C) 2005,2007,2009 Free Software Foundation, Inc.
*
* GRUB is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -27,17 +27,15 @@
* void grub_arch_sync_caches (void *address, grub_size_t len)
*/
FUNCTION(grub_arch_sync_caches)
- save %o6, -0xC, %o6 ! Get a new register window,
- ! reserve space on stack for
- ! %i0, %i1, %i2
- brz,pn %i0, return ! Return if address == 0.
- nop
- brz,pn %i1, return ! Return if len == 0.
- clr %i2 ! index = 0.
-loop: flush %i0 + %i2 ! Flush address + index.
- cmp %i1, %i2 ! Compare len & index .
- bpos,a,pt %xcc, loop ! If len > index, loop.
- add %i2, 8, %i2 ! Go to next doubleword.
-return: ret ! Restore caller's register
- restore ! window and return.
+ brz,pn %o1, 2f
+ add %o0, %o1, %o1
+ add %o1, 7, %o1
+ andn %o1, 7, %o1
+ andn %o0, 7, %o0
+ sub %o1, %o0, %o1
+1: subcc %o1, 8, %o1
+ bne,pt %icc, 1b
+ flush %o0 + %o1
+2: retl
+ nop
--
1.6.2.1.222.g570cc
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
