On Saturday 11 April 2009 08:48:07 phcoder wrote: > Hello, here is the preboot hooks support. Apply on top of my bootmove > patch. They are very useful for patches like sendkey (my old patch that > I'll rediff), badram, acpi (2 patches in separate threads) or drivemap
Some comments about the design. - register/unregister is more appropriate than add/remove. - preboot is ambigous. preboot_hook is better. - Using an int value for the priority is quetionable. Very often, this style of priority system leads to chaos, because everyone picks up arbitrary numbers randomly. I prefer to define enums with a careful analysis. Regards, Okuji _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
