On Sun, 2009-05-03 at 12:42 +0200, Vladimir 'phcoder' Serbinenko wrote: > This is a patch to support UUIDs on HFS+. MD5 code is copied from > Michael Gorven's patch which is copied from libgcrypt nearly verbatim. > Thanks for Cris for the info about how xnu expects UUID to be
I suggest that you run all new code through GNU indent. Spacing in "32-(n)" will probably need to be fixed manually, as it's a preprocessor directive. Commented out call to to _gcry_burn_stack() should probably be removed. I would prefer that we don't use #undef. Instead, the preprocessor defines should use unique names that never need to be redefined. Setting two environment variables is undocumented. I think rd_string should not be needed. If you need it due to the script engine problems, it's better to fix the script engine. At least please mark that hack as a hack. Perhaps we should consider adding %X support to grub_printf(). I realize that it will increase the core slightly, but if it's just a few bytes, we could accept it. Other modules may use it. Or maybe we could have grub_toupper(), perhaps an inline function? Another thing to consider is whether md5 support should be in a separate file. It would make it possible to reuse md5 for other commands. -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
