On Wed, 2009-06-17 at 15:27 +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. This is a fix for problem in subject line. I believe this fix > to be correct and legitimate but as I don't know ruby well could > someone review it? If nobody knows ruby in depth I think we can commit > this even without deep review
I would prefer that we take a different approach with grub-emu. I think the USB support should be enabled whenever libusb is enabled. If libusb is missing, then the USB related code should be omitted from the sources using preprocessor directives. The build system doesn't need to know anything about it. Generally, please think how to reduce complexity, not how to add to it. Complex systems are harder to maintain. -- Regards, Pavel Roskin _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
