On Fri, 2009-06-19 at 19:01 +0200, Vladimir 'phcoder' Serbinenko wrote:

> 8) Removed spaces before labels

Oh, I missed that.  I think we should follow GNU indent in the label
placement as well.

> it has put { on new line and without spacing
> Perhaps something more. The patch would be 77280 lines. If someone
> there would be a way to check indent doen't introduce bugs we could
> run it sometimes on all .c files.

I'm sure it doesn't introduce bugs, but it can mangle some code.

My point is that we should accept the code processed by GNU indent
without any additional changes unless GNU indent obviously mangles the
code.  There should be no coding conventions that GNU indent doesn't
follow.

I don't think we need to reindent everything.

-- 
Regards,
Pavel Roskin


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to