On Fri, Jun 26, 2009 at 12:44:07PM -0400, Pavel Roskin wrote: > On Fri, 2009-06-26 at 16:41 +0200, Robert Millan wrote: > > On Thu, Jun 25, 2009 at 04:51:11PM -0400, Pavel Roskin wrote: > > > > > > I'd like to avoid preprocessor conditionals in kern/ARCH/dl.c files if > > > possible. > > > > Alright, here's a new patch. It follows your earlier suggestion to use > > a wrapper to obtain the initialization address for symtab. This way we > > don't put any ifdefs in kern/ARCH/dl.c files. > > > > I also avoid the #undefs in efiemu. This required many changes in > > loadcore.c, but they're just a sed search & replace run. > > More redefinitions are needed to make all platforms compile. At this > point I think maybe we should try something less intrusive. But anyway, > 02-elf-renames.patch contains those renames. > > 03-simple-symtab.patch simplifies the logic in kern/ARCH/dl.c files.
03-simple-symtab.patch looks nice, much cleaner than what I had. But as for 02-elf-renames.patch we could try to make this more consistent. In efiemu I used 'W' (inspired by ElfW() macro in glibc), then in some places you use 'K' and in other places 'T'. Can we use the same everywhere? I don't care which letter, I'm not THAT much into bikeshed :-) -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
