El jue, 23-07-2009 a las 17:40 +0200, Vladimir 'phcoder' Serbinenko escribió: > Actualy I should have used ALIGN_UP here It's just a random sample of code, brought up by a search for (long). I'm pretty sure more examples abound.
> > Regarding the ChangeLog entry, I always have problems with them. What > > about this one?: > > 2009-07-23 Javier Martin <lordhab...@gmail.com> > > * include/grub/types.h (GRUB_CPU_SIZEOF_VOID_P): substitute for > This would suggest that you modify GRUB_CPU_SIZEOF_VOID_P macro which > isn't the case. I would prefer something like: > [GRUB_CPU_SIZEOF_VOID_P == 8]: Changed to ... > [GRUB_CPU_SIZEOF_LONG == 8]: ... this. Ok, let's adopt this form instead. The proposed ChangeLog would now be: 2009-07-23 Javier Martin <lordhab...@gmail.com> * include/grub/types.h [GRUB_CPU_SIZEOF_VOID_P == 8]: Changed to ... [GRUB_CPU_SIZEOF_LONG == 8]: ...this (UINT_TO_PTR): move outside wordsize conditionals (PTR_TO_UINT): new macro -- -- Lazy, Oblivious, Recurrent Disaster -- Habbit
signature.asc
Description: Esto es una parte de mensaje firmado digitalmente
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel