Am Freitag, den 24.07.2009, 22:37 +0200 schrieb Vladimir 'phcoder' Serbinenko: > On Fri, Jul 24, 2009 at 10:09 PM, Pavel Roskin<pro...@gnu.org> wrote: > > On Fri, 2009-07-24 at 20:46 +0200, Felix Zielcke wrote: > >> And another bug forward > >> Anyone has an idea why a dm-crypt/lvm leads to a segfault in the strcmp > >> here: > >> grub_partition_iterate (dest_dev->disk, (strcmp (dest_partmap, > >> "pc_partition_map") ? > >> find_usable_region_gpt : > >> find_usable_region_msdos)); > > > > dest_partmap is only assigned a value in identify_partmap. If > > grub_partition_iterate() doesn't find any partitions, dest_partmap > > remains a random pointer. > > > > The fix would be probably to initialize dest_partmap with NULL. If it > > becomes "pc_partition_map", iterate with find_usable_region_msdos, if it > > becomes "gpt_partition_map", iterate with find_usable_region_gpt. If > > it's NULL or another string, exit with a warning. > Actualy I already fixed this in my patch for installing on > partitionless devices. Since there were no oppositions I'll commit it
Thanks, it fixed the segfault for Jean-Luc. -- Felix Zielcke Proud Debian Maintainer _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
