On Fri, Jul 24, 2009 at 1:41 AM, Pavel Roskin<pro...@gnu.org> wrote: > On Thu, 2009-07-23 at 11:52 +0200, Vladimir 'phcoder' Serbinenko wrote: >> Hello. Here is a framebuffer split which has already been discussed. >> This patch contains some code by Collin D Bennett in addition to my >> code. Sorry for compression but maillist server doesn't accept it otherwise > > Please include an uncompressed ChangeLog entry. Coming when I have a bit more time > grub_video_vbe_set_viewport and grub_video_vbe_get_info_and_fini need to > be declared static to avoid compiler warnings. > Done > Apart from that, no warnings are introduced. > > Please don't add trailing whitespace. Since you are using git, you can > easily check it with STGit by running "stg edit -d". > I used git diff --color but few whitespace slipped in > grub_video_vbe_get_info_and_fini strikes as a weird name. The comment > says: > > /* Get information about active video mode. */ > > Likewise, all occurrences of "get_info_and_fini" should probably be > replaced with something more descriptive. > I don't see which comment you refer to but I added a comment to grub_video_get_info_and_fini explaining why it's needed > -- > Regards, > Pavel Roskin > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel >
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
framebuf.diff.gz
Description: GNU Zip compressed data
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
