On Sun, Sep 06, 2009 at 08:03:31PM +0200, Felix Zielcke wrote: > I think we shouldn't tell users to type `help' if the command doestn't > exist in rescue mode, i.e. minicmd isn't included in core.img > This increases the size of kernel.img for me by 28 bytes. I think it's > worth. > > It's so small I don't bother to attach it: > > 2009-09-06 Felix Zielcke <fziel...@z-51.de> > > * kern/rescue_parser.c (grub_rescue_parse_line): Only suggest to try > `help' if the command exists. > > diff --git a/kern/rescue_parser.c b/kern/rescue_parser.c > index 79f32b8..1e0841e 100644 > --- a/kern/rescue_parser.c > +++ b/kern/rescue_parser.c > @@ -61,7 +61,8 @@ grub_rescue_parse_line (char *line, grub_reader_getline_t > getline) > else > { > grub_printf ("Unknown command `%s'\n", name); > - grub_printf ("Try `help' for usage\n"); > + if (grub_command_find ("help")) > + grub_printf ("Try `help' for usage\n"); > } > > quit:
Seems fine. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel