Robert Millan wrote:
> Hi,
>
> -Werror is not in effect. This will help ensuring that all new code is
> checked to be warning-free before commit (incidentally, I found a newly
> introduced bug thanks to this just minutes before enabling it).
>
>
If you mean this change:
+ /* Any value different than `p.offset' will satisfy the check during
+ first loop. */
+ lastaddr = !p.offset;
+
Then there was no bug here.
if (labeln && lastaddr == p.offset)
return grub_error (GRUB_ERR_BAD_PART_TABLE, "loop detected");
labeln++;
if ((labeln & (labeln - 1)) == 0)
lastaddr = p.offset;
labeln is 0 during first loop run and then lastaddr is set. I explicitly
omitted initing variables to have smaller loop detector
> Since -Werror may be a problem in some situations, I've added a
> --disable-werror switch, which does the obvious thing.
>
>
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
