On Mon, Nov 16, 2009 at 11:32:52PM +0100, Jordi Mallach wrote: > On Mon, Nov 16, 2009 at 08:56:06PM +0100, Robert Millan wrote: > > > > > +#define _(str) gettext(str) > > > > And I'm not sure if this is the right place to define _. Isn't there > > > > a system-wide definition? > > > This, and others, sometimes go in a common .h to avoid duplication. Many > > > grub utilities are going to add this kind of stuff. > > I wonder where would we put this. Is there any convention? > > I'm not aware of any convention, not even for GNU packages. nls.h, i18n.h, > grub-i18n.h. You name it. :)
Ok. <grub/i18n.h> then. > > > I haven't tested this patch yet, but I'm not sure if a bindtextdomain() > > > call is needed here too. > > This requires LOCALEDIR. Should we add po.m4 in order to get this, or > > just define it ourselves? > > *shrug*, I think just assuming the usual $(datadir)/locale is ok. po.m4 > does provide checks for the gettext tools iirc, though, so that might > be useful in its own right. I enabled AM_GNU_GETTEXT() which drags that in, as well as a few of the other declarations we needed. Thanks! -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
